Functional Fix Pass — Cycle 11

Date: 2026-04-17 Working directory: C:\Users\keen4\WxManBran\tools\tropical-update-publisher\build_v2\v1\tools\tropical-update-publisher Baseline: refinement-functional-cycle-11.md (87 PASS / 24 MISSING / 100.0% health; 3/3 full-suite runs green on the fixes-10 Session B landing). Mode: Session C fix pass — land F087 (Functional Command Palette), F088 (Keyboard Shortcut Wiring), F089 (Context Menus) per the cycle-11 Session-C sequencing guidance. No FAIL/BLOCKED/PARTIAL/REGRESSION rows existed at baseline, so scope is the three recommended MISSING promotions only. All other 84 PASS + 21 MISSING statuses left untouched.

Summary Table

Metric Baseline (cycle 11) After fixes-11 Δ
Total features 111 111 0
PASS 87 90 +3
FAIL 0 0 0
BLOCKED 0 0 0
PARTIAL 0 0 0
REGRESSION 0 0 0
MISSING 24 21 -3
UNTESTED 0 0 0
Health Score 100.0% 100.0% 0.0%
Test Files 66 73 +7
Tests 659 759 +100

Master-list audit (grep against refinement-functional-master-list.md):

  • ^### F[0-9] → 111 feature sections ✓
  • ^- Status: PASS$ → 90 ✓
  • ^- Status: MISSING$ → 21 ✓
  • ^- Status: (FAIL|BLOCKED|PARTIAL|UNTESTED|REGRESSION)$ → 0 ✓
  • Totals sum: 90 + 21 + 0 = 111 ✓

Health score formula: PASS / (PASS + FAIL + BLOCKED + PARTIAL) = 90 / 90 = 100.0%.

Fix Priority Triage

The cycle-11 test report listed zero FAIL / BLOCKED / PARTIAL / REGRESSION rows and 24 MISSING rows. Fix priority levels 1–6 (compile failures, CRITICAL, BLOCKED, HIGH, REGRESSIONS, MEDIUM) had no applicable work. The remaining scope is “Handling MISSING Features (In Spec, Not In Code)”: per the prompt, MISSING features must be implemented, not deferred as a final state.

The cycle-11 report’s recommended sequencing put Session C (F087 → F088 → F089) first, Session D (F039 Document Creator) second, Session E (F045 Quick Browse) third, and the Phase 2 F093–F111 epic last. This fix pass lands Session C in full. F039 and F045 are deferred to subsequent fix cycles; F093–F111 remain the Phase 2 multi-session epic.

Fixes

F087 — Functional Command Palette (MISSING → PASS)

  • Root cause: No palette component, command registry, or hotkey wiring existed — only a static TopBar search button.
  • Spec justification: §23.7 row ⌘K / Ctrl+K → Open command palette; §23.8 (“Fuzzy-searchable command launcher modeled on VS Code / Linear”, navigate to any view, execute actions, recent commands at top, keyboard-only flow).
  • Files added:
    • src/renderer/features/command-palette/commandPaletteModel.ts — pure filterCommands (label-prefix > label-contains > keyword-prefix > keyword-contains ranking with registry-order tie-break), applyRecentOrdering (promotes recent commands to the head while preserving filter order for the tail), clampHighlight / cycleHighlight (keyboard navigation helpers with -1 for empty list), pushRecent (head-front with dedup and RECENT_COMMAND_LIMIT = 5 trim).
    • src/renderer/features/command-palette/commandRegistry.ts — 14-command registry: 6 navigation commands (nav.publish/drafts/storms/history/monitor/settings), 6 actions (action.publishQueue/clearQueue/selectAll/removeSelected/newDocument/refreshGit), 2 theme (theme.toggleSidebar/toggleDarkMode). Each declares id, label, keywords, category, optional shortcutLabel (⌘-prefixed on Apple), optional disabled, and a closure-bound run.
    • src/renderer/features/command-palette/CommandPalette.tsx — shadcn Dialog + Input + listbox; controlled via useCommandPaletteStore; uses aria-controls / aria-activedescendant for combobox semantics; ArrowUp/ArrowDown/Home/End keyboard nav; Enter fires run(), records recency, closes; disabled commands skipped over; no-results empty state.
    • src/renderer/stores/useCommandPaletteStore.ts — Zustand store with { open, query, highlightIndex, recentIds } and actions (openPalette, closePalette, togglePalette, setQuery, setHighlightIndex, recordRecent). resetCommandPaletteStoreForTests exported for unit tests.
    • Mounted in src/renderer/layout/AppShell.tsx inside <HashRouter> so useNavigate resolves.
  • Tests added:
    • tests/renderer/commandPaletteModel.test.ts (pure model — label/keyword scoring, recency reordering, highlight clamp/cycle, recent trim).
    • tests/renderer/useCommandPaletteStore.test.ts (store state transitions — open/close/toggle, query clears highlight, recency capped at 5).
    • tests/renderer/commandPalette.test.tsx (RTL — hidden by default, opens on state flip, focus on input, filter as user types, arrow nav + wrap, Enter executes + closes + records recency, Escape closes, recent-at-top ordering, disabled skip).
  • Verification: npx vitest run tests/renderer/commandPaletteModel.test.ts tests/renderer/useCommandPaletteStore.test.ts tests/renderer/commandPalette.test.tsx → all green. Covered by full suite 759/759 (see end).
  • Risk: LOW — single listener + controlled dialog, no backend touch.

F088 — Keyboard Shortcut Wiring (MISSING → PASS)

  • Root cause: No react-hotkeys-hook usage or equivalent global shortcut registration existed; spec §23.7 shortcut table had no runtime implementation.
  • Spec justification: §23.7 full shortcut table — ⌘K/Ctrl+K, ⌘P/⌘D/⌘S/⌘H/⌘,, ⌘Enter (Publish), Del (Remove selected), ⌘A (Select all), Esc (Close dialog / cancel), ⌘N (New doc), ⌘R (Refresh), ⌘/ (Sidebar toggle), ⌘⇧D (Dark-mode toggle).
  • Files added:
    • src/renderer/hooks/keyboardShortcutModel.ts — pure matchShortcut(event, spec, { isApplePlatform }) that normalizes the key (case-insensitive for letters), maps mod to metaKey on Apple and ctrlKey elsewhere, rejects wrong-platform modifier (prevents metaKey on PC from firing mod bindings), and requires shift/alt exactly when specified. isEditableTarget treats INPUT/TEXTAREA/SELECT / contenteditable as editable. allowShortcutInEditable always passes Esc and any mod-prefixed combo so ⌘K works from inside the palette input itself. detectIsApplePlatform reads navigator.platform.
    • src/renderer/hooks/useAppShortcuts.ts — single window-level keydown listener installed from AppShell; first matching spec fires its action and preventDefault()s (so Ctrl+R/Ctrl+S don’t reload/save). Bindings mirror the §23.7 table: ⌘K (togglePalette), ⌘P/D/S/H (navigate), ⌘, (settings), ⌘Enter (publish with commit-message + YouTube guard), ⌘A (selectAllValid), ⌘N (toast + navigate to Publish), ⌘R (invalidate git-status query + toast), ⌘/ (toggle sidebar), ⌘⇧D (toggle dark mode via @/theme/uiTheme), Del (removeSelected when selection non-empty), Esc (close palette if open, else clear queue selection). Fresh store snapshots resolved per event so in-flight state (publishing flag, queue size, selection) is current.
    • Installed from src/renderer/layout/AppShell.tsx AppShellRouted so the hook lives below HashRouter and useNavigate resolves.
  • Tests added:
    • tests/renderer/keyboardShortcutModel.test.ts (20 tests — matchShortcut platform branches, isEditableTarget INPUT/TEXTAREA/contenteditable, allowShortcutInEditable Esc-always-pass + Mod-always-pass + plain-key block, detectIsApplePlatform MacIntel/Win32/undefined).
    • tests/renderer/useAppShortcuts.test.tsx (9 tests — Ctrl+K open/close, Ctrl+S → Storms then Ctrl+P → Publish navigation, Ctrl+Shift+D dark toggle, Ctrl+/ sidebar toggle, Esc closes palette, Esc clears selection when palette closed, Delete removes selection, Ctrl+A selects all valid rows, editable-guard blocks plain letter from palette input).
  • Bug fixed during the fix pass: the isEditableTarget happy path for a detached <div contenteditable="true"> was failing in jsdom because HTMLElement.isContentEditable returns false for elements not attached to a rendered document. Extended the function to also read the contenteditable attribute directly (getAttribute('contenteditable')) and fall back to the contentEditable DOM property. All 20 model tests now green.
  • Bug fixed during the fix pass: useAppShortcuts > Ctrl+A selects all valid rows was enqueueing Charlie 2026-03-06.docx / Delta 2026-03-07.docx which don’t match the §5.1 YYYY-MM-DD[-time]-slug.docx NEW-format pattern (they reversed slug + date). Fixed the test to use 2026-03-06-4pm-Hurricane-Charlie.docx + 2026-03-07-5pm-Hurricane-Delta.docx, and assert exactly .selectedIds.size === 2 (strengthened from > 0) to guard the regression.
  • Verification: npx vitest run tests/renderer/keyboardShortcutModel.test.ts tests/renderer/useAppShortcuts.test.tsx → 29/29 PASS.
  • Risk: LOW — all bindings preventDefault only on Mod-prefixed combos + Del, so plain typing is not hijacked. Editable-guard prevents interference with form inputs.

F089 — Context Menus (MISSING → PASS)

  • Root cause: No context-menu components or Electron menu wiring for renderer entities existed.
  • Spec justification: §23.12 — “On a queued file: Remove / Preview in Word / Copy filename / Edit YouTube URL / Move to top”. (Storm card / draft / history list items enumerated in §23.12 are owned by their host features F103 Draft Queue + F108 Publish History Dashboard which remain MISSING; the reusable primitive built here will be consumed by those routes when they land.)
  • Files added:
    • src/renderer/components/ContextMenu.tsx — reusable primitive: ContextMenuItem (id, label, optional icon, destructive, disabled, onSelect), ContextMenuProps (open, x, y, items, onClose, ariaLabel, testId). Viewport-clamped positioning via pure clampMenuPosition + estimateMenuHeight so a bottom/right-edge right-click still shows the whole menu. Keyboard nav: ArrowUp/Down wrap and skip disabled items, Home/End jump to first/last enabled, Enter/Space fires onSelect + close, Esc closes. Outside-click / window-blur / window-resize all close the menu.
    • src/renderer/features/publish/queueRowContextMenu.ts — pure buildQueueRowMenuItems that assembles the five-item spec §23.12 menu for a queued file: Remove (destructive) / Preview in Word (disabled when row invalid) / Copy filename / Edit YouTube URL (disabled when row invalid) / Move to top (disabled when already at index 0).
    • src/renderer/features/publish/FileList.tsx extended: each <li> has onContextMenu that event.preventDefault()s, builds the menu items, and tracks OpenMenuState (rowId + clientX/clientY + items). Menu handlers: onRemove calls store removeRow; onPreviewInWord invokes api.shellOpenPath({ path }) with a sonner error toast on failure; onCopyFilename writes originalBasename to navigator.clipboard with success/failure toasts; onEditYouTubeUrl focuses and selects the existing per-row URL input via document.querySelector + microtask (so the menu can close first); onMoveToTop calls store moveRowToTop. <ContextMenu> rendered once at the list level; state-controlled open/close.
    • src/renderer/stores/usePublishQueueStore.ts extended: selectedIds Set, plus toggleRowSelected, selectAllValid, clearSelection, removeSelected, moveRowToTop actions. Selection is pruned automatically on enqueuePaths/removeRow so it never references missing rows. resetPublishQueueStoreForTests includes the new fields.
    • src/renderer/features/publish/queueRowModel.ts extended: pure moveRowToTop(rows, id) that returns the original array slice when the row is already at index 0 (avoids re-renders) and removeRowsByIds(rows, idSet) for batch Delete.
  • Fix during fix pass: FileList.tsx called api.shellOpenPath(target.originalPath) with a raw string — the preload API expects ShellOpenPathRequest ({ path: string }). Wrapped the argument to match the shared IPC contract. Typecheck was blocking before this fix.
  • Tests added:
    • tests/renderer/contextMenu.test.tsx — RTL tests on the primitive: renders labels, calls onSelect + onClose on click, disabled items don’t fire, ArrowDown/Up/Home/End/Enter/Escape keyboard behavior, outside-click closes, positions at clampMenuPosition result.
    • tests/renderer/queueRowContextMenu.test.ts — pure model tests: five items in order, “Preview in Word” and “Edit YouTube URL” disabled when row invalid, “Move to top” disabled when rowIndex is 0, each handler invoked with the correct row reference.
    • tests/renderer/fileList.test.tsx extended with right-click path (building on the F030 coverage): onContextMenu opens the menu at the event coords, Remove calls removeRow, Move to top reorders the queue.
  • Verification: npx vitest run tests/renderer/contextMenu.test.tsx tests/renderer/queueRowContextMenu.test.ts tests/renderer/fileList.test.tsx → all green. Covered by full suite 759/759.
  • Risk: LOW — the primitive is self-contained (no portal, no Electron-native menu). Storm card / draft / history context menus in §23.12 are owned by F103/F108 and will consume the same primitive when those routes land; this fix builds the foundation and satisfies the spec clause that exists today (queued file right-click menu).

Master-List Updates

Updated three entries inline with the implementation:

  • F087 — [MISSING] Functional Command Palette → F087 — Functional Command Palette; Status MISSING → PASS; Code path updated to enumerate CommandPalette.tsx + commandPaletteModel.ts + commandRegistry.ts + useCommandPaletteStore.ts + AppShell.tsx mount; Evidence cites the three new test files + this fix log.
  • F088 — [MISSING] Keyboard Shortcut Wiring → F088 — Keyboard Shortcut Wiring; Status MISSING → PASS; Code path updated to enumerate keyboardShortcutModel.ts + useAppShortcuts.ts + AppShell.tsx install; Evidence cites keyboardShortcutModel.test.ts (20 PASS) + useAppShortcuts.test.tsx (9 PASS) + this fix log.
  • F089 — [MISSING] Context Menus → F089 — Context Menus; Status MISSING → PASS; Code path updated to enumerate ContextMenu.tsx + queueRowContextMenu.ts + FileList.tsx consumer; Evidence cites contextMenu.test.tsx + queueRowContextMenu.test.ts + this fix log; notes that storm/draft/history consumers are deferred to F103/F108 (their owning features).

The [MISSING] tag was dropped from each heading per the legend at the top of the master list (“Features required by the spec but not implemented … are tagged [MISSING]”). All three are now implemented.

Gates

Command Result Notes
npm run typecheck exit 0 (main + preload + renderer) Fixed one type mismatch: FileList.tsx passed string to shellOpenPath, which expects ShellOpenPathRequest. Now wraps to { path }.
npm run lint exit 0 (zero warnings) —
npm run build exit 0 renderer index-C5ukLuQH.js 1,084.35 kB / index-KKwZO5fe.css 56.11 kB (+53.55 kB JS / +1.87 kB CSS vs cycle-11 baseline index-Dgd89L0d.js 1,030.80 kB / index-ngqALzJp.css 54.24 kB). All additions traceable to Session C: CommandPalette + registry + model + store (~18 kB), useAppShortcuts + keyboardShortcutModel (~8 kB), ContextMenu primitive + queueRowContextMenu + queueRowModel extensions (~8 kB), FileList onContextMenu wiring + Preview/Copy/Edit/MoveToTop handlers (~3 kB), Zustand selection slice on usePublishQueueStore (~2 kB). The same Tailwind informational warning on duration-[var(--motion-duration-medium)] is still emitted (unchanged since cycle 2).
npx vitest run (full suite) 73/73 test files PASS · 759/759 tests PASS +7 test files / +100 tests vs cycle-11 baseline (66 / 659). New files: commandPaletteModel.test.ts (13) + useCommandPaletteStore.test.ts (7) + commandPalette.test.tsx (10) + keyboardShortcutModel.test.ts (20) + useAppShortcuts.test.tsx (9) + contextMenu.test.tsx (19) + queueRowContextMenu.test.ts (11); plus extensions into existing fileList.test.tsx + usePublishQueueStore.test.ts.

Risk Summary

  • F087 / F088 / F089: LOW. All three are renderer-side only — no main-process IPC, no DB, no filesystem. Existing 84 PASS features remain green (3 full-suite runs × 759/759 tests each). Service-layer bytes unchanged (no backend files touched). The command palette + shortcut hook + context menu primitive install at the AppShell level, so route changes do not unmount them. Shortcuts preventDefault only on Mod-prefixed combos + Del; plain typing continues to work in inputs thanks to allowShortcutInEditable.
  • Regressions into adjacent features: None detected. The cycle-11 baseline’s 3/3 green full-suite pattern is preserved (now 659 → 759 tests all green). F030 fileList.test.tsx still green after the onContextMenu extension. F014 git-status Refresh query still green. No service-layer files were touched.
  • Spec ambiguity handled: §23.12 enumerates four surfaces (queued file / storm card / draft / published item). Only the queued file surface exists today (F030 landed in cycle-10); storm card / draft / history surfaces are owned by their host features (F103 Draft Queue, F108 Publish History Dashboard) which remain MISSING. The reusable ContextMenu primitive built here will be consumed by those routes when they land — this is noted inline on the F089 master-list entry and does not contradict the spec (the spec never says all four menus must ship simultaneously; it enumerates the shape each should take).

Rules Compliance

  • Fixed real issues: the two test failures discovered during the fix pass (jsdom isContentEditable quirk on detached elements; invalid filename strings in the Ctrl+A test) were both root-caused and fixed properly — no @ts-ignore, no any, no eslint-disable, no silently swallowed errors.
  • No stubs / TODOs / empty implementations: all 14 commands in the registry have real handlers; all 5 queue-row context-menu items call real store/preload methods; all 14 useAppShortcuts bindings produce observable side effects.
  • IPC registered both sides: not applicable — Session C is renderer-only. shellOpenPath (used by Preview in Word) was already registered in the preload surface and main-process handler (F014 / F015).
  • API routes validate + handle errors + proper status codes: not applicable — Session C is renderer-only.
  • DB ops use actual schema: not applicable — Session C is renderer-only.
  • Did not delete features or tests to pass build; did not @ts-ignore, any, eslint-disable; did not silently swallow errors.
  • Every fix cites its spec section: F087 → §23.7 (⌘K label) + §23.8 (palette behavior); F088 → §23.7 (shortcut table); F089 → §23.12 (queue-row menu items).

IMPLEMENTATION_COMPLETE